Tried to contribute issues

Starting...

I had no idea how I could contribute, create, and fix an issue. I was afraid of messing up other's repository. Anyway, I have to try in order to follow the curriculum. I forked and cloned one of my classmates' repository. It was my first time to test codes implemented by someone else.

Reading...

I went through the codes and tried to find any issue, were not easy at all. Anyway, the first issue I found is a very tiny thing: 'let' keyword although that never changed. It would be better to use 'const' keyword I think.

Another issue is that the person did not use .gitignore . Although, I think it is not a big issue in here, It would be also better to node_modules in .gitignore to prevent accidently upload huge setting file to git.

Lastly, It seems to have similar issues that I had already in my source code. It was about the wrong way like using async or promise functions as sync functions. The call of each urls tried to request a call to get status code one by one.

Thus, I tried to fix that issue too. I created another branch and tried use Promise.all instead of for statement and it turned out that the result was faster than before.

The issue link and Forked repository

After fixed the issues, there was the button displayed for pull request so I clicked it and another step came out for it.

Once I created pull request, I realized the git checked all of things if there was a conflict or not. Of course, I also met the conflict and I fixed. Now, I know why people like git a lot especially for team project.

Although the owner of the repository refused to merge my fixed code, it was a great experience and now I know how I can contribute my work in open source world.

Comments

Working with telescope

Starting... This lab is to help students to communicate with a big project, telescope, and understanding how to handle with the set it up. There were a lot of trouble since many of technologies are new for me such as docker, docker-compose, elastic search ladis, pino, and so on. Let's jump in the big project . Progressing... The first step I took is to install wsl 2. It is not very difficult since microsoft provides good instruction, link . Although the telescope provides very good instruction, here , It was not really easy for me to get a concept and set it up successfully. Therefore, I needed to ask a lot of questions on slack, telescope channel. Some helped me a lot and explained so much and finally I got it work successfully. After my server was working locally, I didn't have any issue to get the response from the url, http://localhost:3000/posts. To communicate with the local server, actually I needed to change my code a lot since I wanted to sp...

Getting more difficult?

Release 0.2.4 Now I am at almost the end of release 0.2 and I chose the telescope as the final contribution. To be honest, this is huge, well organized and great project and it is first time to take a look. Unlike my previous assignment during the previous terms, there are tons of what I have never seen. First, docker compose is great and the document for contribution is very clear. Of course, I had no idea when read it first, but every time as my professor mentioned, there was a great guy, helper?, helping me a lot to set up the project. Although I had no idea about Elastic-search and Redis-cache server, I was happy to take a time to look though the codes and to understand. Again, trying to understand an issue is always hard for me and sometimes I am really not happy when somebody does not understand my question. This happened again. The reason why I attached the picture is that I am still confused about the whole process of this project especially about why frontend didn't get ...

Elastic search and more

Release 0.3.1 Now it is time to learn what is Elastic search since the chosen issue is about adding more fields for our model in telescope. This is very new for me so I was very scared when I started to work for this but now I think I am more confident. First, Elastic search is such a great supportive database especially for index search. The good thing is that it is not only the index search for whole value but, partial keyword as well. Of course, it may be wrong since I also just started to study it. Anyway, It was very careful when I read codes one line by one. Following the official document , I tried to add some fields, but it made some test failed so I needed to fix them. The below content is from the official document: Mapping edit Mapping is the process of defining how a document, and the fields it contains, are stored and indexed. For instance, use mappings to define: which string fields should be treated as full text fields. which fields contain numbers, dat...

Stella's Blog

Search This Blog