Tried to contribute issues

Starting...

I had no idea how I could contribute, create, and fix an issue. I was afraid of messing up other's repository. Anyway, I have to try in order to follow the curriculum. I forked and cloned one of my classmates' repository. It was my first time to test codes implemented by someone else.

Reading...

I went through the codes and tried to find any issue, were not easy at all. Anyway, the first issue I found is a very tiny thing: 'let' keyword although that never changed. It would be better to use 'const' keyword I think.

Another issue is that the person did not use .gitignore . Although, I think it is not a big issue in here, It would be also better to node_modules in .gitignore to prevent accidently upload huge setting file to git.

Lastly, It seems to have similar issues that I had already in my source code. It was about the wrong way like using async or promise functions as sync functions. The call of each urls tried to request a call to get status code one by one.

Thus, I tried to fix that issue too. I created another branch and tried use Promise.all instead of for statement and it turned out that the result was faster than before.

The issue link and Forked repository

After fixed the issues, there was the button displayed for pull request so I clicked it and another step came out for it.

Once I created pull request, I realized the git checked all of things if there was a conflict or not. Of course, I also met the conflict and I fixed. Now, I know why people like git a lot especially for team project.

Although the owner of the repository refused to merge my fixed code, it was a great experience and now I know how I can contribute my work in open source world.

Comments

Experience about a contribution to fix a bug or issue

Starting... I have been very exciting to review other classmates' repository before I will jump into a real open source project. From this lab, I have learned how to do forking and cloning other projects and create a new branch for a new issue or a new feature. It is very hard to wait for the owner's answer but it also can be a special experience Reading... In my experience, finding an issue and improvement is not easy especially for other's task and really careful to touch it since it should be very sensitive. For this reason, my first step for this lab, I tried to create an issue with a nice comment. During the time for waiting for reply, I did forking and cloning the repository and started to review a code to find out what I can contribute. Finally, I figured out some part I can improve so I added comment for it, Issue 5 I suggested three things. First of all, the number of counter is always the last number so I wanted to fix it. Second, I wanted to add an another ...

Working with telescope

Starting... This lab is to help students to communicate with a big project, telescope, and understanding how to handle with the set it up. There were a lot of trouble since many of technologies are new for me such as docker, docker-compose, elastic search ladis, pino, and so on. Let's jump in the big project . Progressing... The first step I took is to install wsl 2. It is not very difficult since microsoft provides good instruction, link . Although the telescope provides very good instruction, here , It was not really easy for me to get a concept and set it up successfully. Therefore, I needed to ask a lot of questions on slack, telescope channel. Some helped me a lot and explained so much and finally I got it work successfully. After my server was working locally, I didn't have any issue to get the response from the url, http://localhost:3000/posts. To communicate with the local server, actually I needed to change my code a lot since I wanted to sp...

Start new journey for oauth2

Release 0.4 For the release 4, I decided to contribute the issue that I failed to contribute since the owner changed language. This is my final goal for this course so I don't want to cotribute just one line code or edit a document. Fortunately, there was an issue when I visited the repository again so I added a comment again to get the issue. The issue is about adding more oauth2 feature, which is new for me even I have not been touched oauth2 on my academic projects at all. So, It will be fun and I am looking forward to what I will face from this issue.

Stella's Blog

Search This Blog