Release 0.3.1
Now it is time to learn what is Elastic search since the chosen issue is about adding more fields for our model in telescope. This is very new for me so I was very scared when I started to work for this but now I think I am more confident.
First, Elastic search is such a great supportive database especially for index search. The good thing is that it is not only the index search for whole value but, partial keyword as well. Of course, it may be wrong since I also just started to study it. Anyway, It was very careful when I read codes one line by one.
Following the official document, I tried to add some fields, but it made some test failed so I needed to fix them. The below content is from the official document:
Mappingedit
Mapping is the process of defining how a document, and the fields it contains, are stored and indexed. For instance, use mappings to define:
- which string fields should be treated as full text fields.
- which fields contain numbers, dates, or geolocations.
- the format of date values.
- custom rules to control the mapping for dynamically added fields.
Reading a document is always time consuming but, it was great time to learn and now I didn't add date field but I learned we cannot use date time search as a string automatically. For this, the code should be care of date converting part.
After asking a lot of questions and many commits, finally I got the PR approval. During the period that I work on, I did not really enjoy it since a lot of parts are new and even now many of parts are not sure yet. But, I believe that I will be OK and more familiar with this project.
In conclusion, the difficulty is not about how many code I should write, but how much time I should care. What I mean by that, as you can see, in my PR, only a few line of codes are modified. However, I spent a lot of time to read a document and codes even including test case as well To be honest, I really don't know how to write a test case as well so I will look for test issue as a next one.
Comments
Post a Comment